Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 'jumping' issue when capturing screenshot #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tpalmer
Copy link

@tpalmer tpalmer commented Aug 27, 2015

I noticed that when capturing a screenshot, sometimes the view would zoom in then immediately zoom back out - I don't know if this is the ideal solution to the issue but it solved it for me. Let me know what you think.

@daveverwer
Copy link
Member

Was this happening on device or on the simulator? Can you record a video of it happening please so we can see if we can reproduce it.

Thanks for reporting the issue!

@tpalmer
Copy link
Author

tpalmer commented Aug 27, 2015

I'm seeing it on both device and simulator actually. Here's an animation of it happening in the simulator (right after the 'share this question' button is pressed):

sdscreenshot-jump-bug

@daveverwer
Copy link
Member

Are you seeing this in other apps too? Looks like this is on iOS 9 from the screenshot. Do you see it on 8 as well? Could be something that is specific to iOS 9.

I'm a little reluctant to merge this as is because afterScreenUpdates should really be YES and I'm pretty sure it will break this for other apps. We also don't really know why setting it to NO fixes it which is never a great situation to be in 🙈

Just in case anyone else is reading... Is anyone else seeing this?

@daveverwer
Copy link
Member

Could you also check whether it has the same behaviour when using renderInContext (see https://github.com/shinydevelopment/SDScreenshotCapture/blob/master/SDScreenshotCapture/SDScreenshotCapture.m#L59) as opposed to drawViewHierarchyInRect.

If this fixes the issue for you, maybe there should be some way to force it to use renderInContext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants