Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add zstd #4159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add zstd #4159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Formula/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# typed: true
# frozen_string_literal: true

require File.expand_path("../Abstract/abstract-php-extension", __dir__)

# Class for Zstd Extension
class ZstdAT83 < AbstractPhpExtension
init
desc "Zstd Extension for PHP"
homepage "https://github.com/kjdev/php-ext-zstd"
url "https://pecl.php.net/get/zstd-0.13.3.tgz"
sha256 "e4dfa6e5501736f2f5dbfedd33b214c0c47fa98708f0a7d8c65baa95fd6d7e06"
head "https://github.com/kjdev/php-ext-zstd.git", branch: "master"
license "MIT"

depends_on "zstd"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I cannot provide this bottle info

https://github.com/shivammathur/homebrew-extensions/blob/master/Formula/pcov%408.4.rb#L16-L25

as the ci has to built it?

should I add all versions?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please add formulae for all php versions.

def install
Dir.chdir "zstd-#{version}"
safe_phpize
system "./configure", "--prefix=#{prefix}", "--with-libzstd", phpconfig
system "make"
prefix.install "modules/#{extension}.so"
write_config_file
add_include_files
end
end
Loading