Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shopinvader_api_delivery_carrier: hide delivery line in cart #11

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shopinvader_api_delivery_carrier/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
from . import routers
from . import models
1 change: 1 addition & 0 deletions shopinvader_api_delivery_carrier/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import sale_order_line
16 changes: 16 additions & 0 deletions shopinvader_api_delivery_carrier/models/sale_order_line.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2024 Akretion (https://www.akretion.com).
# @author Sébastien BEAU <[email protected]>
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from odoo import api, models


class SaleOrderLine(models.Model):
_inherit = "sale.order.line"

def _is_visible_in_shopinvader_api(self):
return super()._is_visible_in_shopinvader_api() and not self.is_delivery

@api.depends("is_delivery")
def _compute_visible_in_shopinvader_api(self):
return super()._compute_visible_in_shopinvader_api()
6 changes: 6 additions & 0 deletions shopinvader_api_delivery_carrier/tests/test_set_carrier.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ def test_setting_free_carrier(self):
)
self.assertEqual(response.status_code, 200)
info = response.json()

# Ensure that delivery line is not visible in the cart
delivery_line = self.cart.order_line.filtered("is_delivery")
for line in info["lines"]:
self.assertNotEqual(line["id"], delivery_line.id)

self.assertEqual(info["delivery"]["amount"]["total"], 0)
self.assertEqual(
info["delivery"]["selected_carrier"]["description"],
Expand Down
Loading