-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT-38027 - fix datepicker not emiting value when manually entered #270
Merged
Haberkamp
merged 2 commits into
main
from
next-38027/fix-datepicker-not-emit-value-entered-manual
Sep 11, 2024
Merged
NEXT-38027 - fix datepicker not emiting value when manually entered #270
Haberkamp
merged 2 commits into
main
from
next-38027/fix-datepicker-not-emit-value-entered-manual
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
tajespasarela
force-pushed
the
next-38027/fix-datepicker-not-emit-value-entered-manual
branch
from
August 30, 2024 09:31
e5dc952
to
922b799
Compare
seggewiss
approved these changes
Aug 30, 2024
commit:
|
tajespasarela
force-pushed
the
next-38027/fix-datepicker-not-emit-value-entered-manual
branch
from
September 3, 2024 11:49
922b799
to
5bad673
Compare
tajespasarela
force-pushed
the
next-38027/fix-datepicker-not-emit-value-entered-manual
branch
from
September 3, 2024 12:29
5bad673
to
31b1881
Compare
Haberkamp
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog by using npx changesets
tajespasarela
force-pushed
the
next-38027/fix-datepicker-not-emit-value-entered-manual
branch
from
September 3, 2024 12:53
31b1881
to
1b5fc26
Compare
done |
tajespasarela
force-pushed
the
next-38027/fix-datepicker-not-emit-value-entered-manual
branch
from
September 5, 2024 05:43
417ccf4
to
9e68bc8
Compare
tajespasarela
force-pushed
the
next-38027/fix-datepicker-not-emit-value-entered-manual
branch
from
September 9, 2024 05:46
9fb1902
to
bcf30d0
Compare
Haberkamp
approved these changes
Sep 11, 2024
Haberkamp
deleted the
next-38027/fix-datepicker-not-emit-value-entered-manual
branch
September 11, 2024 13:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This MR fixes an issue with the mt-datepicker, that provokes not saving the date when it is typed manually instead of selected from the calendar.
How?
The solution was to emit the changed value also in the
onClose
hook of theflatpicker
component. This way when user clicks save, it will be emitted.There is another hook
onValueUpdate
but this is emitted multiple times when typed and it is not emitted when the date is deleted manually. So theonClose
hook works better.It was also necessary to update the
flatpickr
dependency to latest version to fix some inconsistent behaviour.Testing?
Should emit date value when manually typed
in storybook