remove default margin from checkbox #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the default margin from the checkbox component.
Why?
The parent component should take care of spacing elements. Not the component itself.
How?
I've removed the default margin depending on whether or not the
removeDefaultMargin
future flag is activated or not.Testing?
The visual tests should catch issues. But feel free to test it yourself by checking out the story for the checkbox.
Anything Else?