Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotated the query with the federation partners #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JervenBolleman
Copy link
Collaborator

Use the ontology created in the ontology branch to annotate that a query federates with certain endpoints.
Tests that the query service clauses match the annotations are also added.

@JervenBolleman JervenBolleman added the enhancement New feature or request label Jul 31, 2024
@JervenBolleman JervenBolleman self-assigned this Jul 31, 2024
…issue), fix ensembl xref between uniprot and bgee (uniprot ensembl IRIs use version number in IRIs, while bgee does not)
@vemonet
Copy link
Member

vemonet commented Aug 2, 2024

There is some issue with Bgee virtuoso which makes services calls to https://www.bgee.org/sparql fail, the ending slash is required for it to work (in SERVICE calls only...), I have added it

And Ensembl xrefs between uniprot and bgee needs a small rewrite to work (uniprot ensembl IRIs use version number in IRIs, while bgee does not)

@vemonet
Copy link
Member

vemonet commented Sep 20, 2024

Wouldn't it better to use spex:federatesWith instead of sparql-examples:federates_with for the predicate? Camecase is usually more commonly used for predicates than snakecase

For the prefix maybe a shorthand like spex: or rqex:? Having - in the left part of a CURIE is authorized but some coloration systems are not working well with it

@JervenBolleman
Copy link
Collaborator Author

@vemonet spex:federatesWith could you give me a link to the ontology file please

@vemonet
Copy link
Member

vemonet commented Sep 20, 2024

The ontology was pushed in a different PR: #22

I can make some improvements to the ontology, should I push it back to this PR 22 or this one?

@JervenBolleman
Copy link
Collaborator Author

I was thinking you where referring to an ontology associated with zazuko spex.
Yes using camelcase is fine I will fix it.

@vemonet
Copy link
Member

vemonet commented Sep 20, 2024

Ah no, I was thinking just changing the prefix since https://prefix.cc/spex was not matching anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants