General:Start introducing language tags #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemonet
reviewed
Aug 29, 2024
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| public class SIB { | |||
| public static final IRI DESCRIBE = SimpleValueFactory.getInstance().createIRI(SHACL.NAMESPACE, "describe"); | |||
| public static final IRI BIGDATA_SELECT = SimpleValueFactory.getInstance().createIRI(SHACL.NAMESPACE, "bigdata_select"); | |||
There was a problem hiding this comment.
Why do we need a separate predicate/class for blazegraph select?
There was a problem hiding this comment.
Because there are many "SPARQL" queries on WikiData that use Blazegraph extensions that are not at all SPARQL 1.1. i.e. we have users outside of SIB now for this code. But that should not have been in this PR. I have accidentally pushed that to this branch :(
There was a problem hiding this comment.
Should be fixed now with a force push
JervenBolleman
force-pushed
the
multi-language
branch
from
cbec538
to
e875c06
Compare
dssib
approved these changes
Aug 29, 2024
dssib
reviewed
Aug 29, 2024
| @@ -5,11 +5,11 @@ | |||
|
|
|||
| ex:11 a sh:SPARQLExecutable, | |||
| sh:SPARQLSelectExecutable ; | |||
| rdfs:label "Mapping HMDB to SwissLipids" ; | |||
| rdfs:label "Mapping HMDB to SwissLipids"@en ; | |||
There was a problem hiding this comment.
why do we have rdfs:label instead of schema:keywords? Do we use both, for different purposes? We should also document this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should tag, when possible the language a string/comment/label is in. To allow for labels in many languages.