Use the independent SPARQL examples utils project #33
Conversation
README.md
Outdated
| @@ -50,26 +50,26 @@ This expects the Jena tools to be available in your $PATH. e.g. `export PATH="$J | |||
| Another option is to build the converter and use that. | |||
There was a problem hiding this comment.
Maybe we should completely deprecate and remove the bash script? (./convertToOneTurtle.sh -p uniprot)
README.md
Outdated
| @@ -50,26 +50,26 @@ This expects the Jena tools to be available in your $PATH. e.g. `export PATH="$J | |||
| Another option is to build the converter and use that. | |||
|
|
|||
| ```bash | |||
| mvn package | |||
| java -jar target/sparql-examples-util-1.0.0-SNAPSHOT-uber.jar -i examples/ -p all -f jsonld | |||
| wget 'https://github.com/sib-swiss/sparql-examples-utils/releases/download/v1.0.0/sparql-examples-util-1.0.0-uber.jar' | |||
There was a problem hiding this comment.
The project name is sparql-examples-utils but the jar is named sparql-example-util without s
Also do we really need to put the version name + uber in the jar file name?
We could consistently release the jar file as sparql-examples-utils.jar, there should be a --version command to get the version. This way user can easily download the latest version in 1 command:
wget 'https://github.com/sib-swiss/sparql-examples-utils/releases/latest/download/sparql-examples-utils.jar'We avoid duplication of the version in the download URL, reduce the changes needed to do when a new release is made, and users can still download a specific version if they want to
README.md
Outdated
| mvn package | ||
| java -jar target/sparql-examples-util-1.0.0-SNAPSHOT-uber.jar -i examples/ -p all -f jsonld | ||
| wget 'https://github.com/sib-swiss/sparql-examples-utils/releases/download/v1.0.0/sparql-examples-util-1.0.0-uber.jar' | ||
| java -jar sparql-examples-util-1.0.0-uber.jar -i examples/ -p all -f jsonld |
There was a problem hiding this comment.
Would this make sense to automatically run the tests when a user generates any artifacts? And add an arguments to skip tests?
Replace the mvn test approach with an utility released in a separate project.