Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error for SE-0409 #184

Closed
wants to merge 1 commit into from
Closed

Conversation

kitwtnb
Copy link
Contributor

@kitwtnb kitwtnb commented Jul 25, 2024

SE-0409 , introduced in Swift 6, changes import from implicit public import to internal import.
The internal import does not allow imports to be public and will result in build errors, so public has been added.
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0409-access-level-on-imports.md

@kitwtnb
Copy link
Contributor Author

kitwtnb commented Jul 25, 2024

CI may need to build with Xcode 16 to resolve build errors. 🫤

@sindresorhus
Copy link
Owner

Swift 6 does not come with this setting on by default, and also, the point of it is to prefer internal import as much as possible.

@kitwtnb
Copy link
Contributor Author

kitwtnb commented Jul 25, 2024

https://forums.swift.org/t/progress-toward-the-swift-6-language-mode/68315#the-swift-6-migration-2

There are a number of previously-accepted upcoming features that will be enabled by default in Swift 6

The forum states that it is enabled by default, but where can I find that it is disabled by default?

@sindresorhus
Copy link
Owner

I don't remember where I saw it, but you can see it in the Xcode beta:

Screenshot 2024-07-25 at 15 44 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants