fix: tcpassembly does not use correct timestamps #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcpassembly only read the bytes of the reassembled stream and ignored other reassembly information, like seen timestamp. Therefore When assembling a HEP packet it had to use the current time. Because of parallel handling of packet capture, reassembly, and extraction this timestamp could be totally wrong. The changed code processes the reassembly information directly and uses the timestamp of the part with the begin of the SIP message. refs: sipcapture#223
|
xhantu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
GREAT contribution! Thanks @xhantu 🎉 |
|
I did not set an email when committing. How do I sign the CLA now that I can not add the email to my account? |
aduplusnet
approved these changes
Feb 1, 2024
lmangani
approved these changes
Feb 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcpassembly only read the bytes of the reassembled stream and ignored other reassembly information, like seen timestamp. Therefore When assembling a HEP packet it had to use the current time. Because of parallel handling of packet capture, reassembly, and extraction this timestamp could be totally wrong.
The changed code processes the reassembly information directly and uses the timestamp of the part with the begin of the SIP message.
refs: #223