Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__package_apt to accept .dpkg file as --source #66

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fancsali
Copy link
Contributor

No description provided.

then
# other version should be installed
name="${name}=${version_should}"
aptget="${aptget:?} -o APT::Get::allow-downgrades=true"

echo "${aptget} ${recommendsparam} install ${target_release} '${name}'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the install command up here breaks the auto-update mechanism below (line 121ff.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. I shall have a think about this aspect.

if [ -f "$__object/parameter/source" ]
then
source_path="$(cat "$__object/parameter/source")"
tempfile="$($__remote_exec $__target_host "mktemp -t cidst.XXXXX.${source_path##*/}")"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't consider executing $__remote_* commands from a gencode-* script good style, as they will also be executed for dry runs.
This section should go to a code-local or, even better, use __file if possible.
Supporting --source -, like __file would also be nice, IMO.

also: cidst -> cdist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's an interesting and important aspect. Thanks for pointing it out.

However, I am in a bit of a pickle here:

  • Putting it into gencode-local wont' really fly here: that will return a filename (and/or create a file) that's unique locally.
  • Putting it into __file would then mean, we need to pass the value from the manifest to the gencode-remote script, which then means setting up temporary files and such, right?

Supporting --sourece - seems to be rather out of scope here: how many people will pipe a .dpkg as a string literal through here?

Typo is a nice catch, thanks.

@sideeffect42 sideeffect42 changed the title __package_apt to accept .dpkg file as --soruce __package_apt to accept .dpkg file as --source Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants