Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix deprecated comment for UploadFile and UploadFileContext #1316

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

shogo82148
Copy link
Contributor

The UploadFile and UploadFileContext have been deprecated, but pkgsite is not aware of it:

image

This pull request fixes it.
pkgsite will mark UploadFile and UploadFileContext as DEPRECATED:

image

And some tools will warn use of UploadFile and UploadFileContext.

See https://go.dev/wiki/Deprecated for more detail.

Copy link
Contributor

@lorenzoaiello lorenzoaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching and fixing it! 🙇

@lorenzoaiello lorenzoaiello changed the title fix: fix deprecated comment for UploadFile and UploadFileContext docs: fix deprecated comment for UploadFile and UploadFileContext Aug 21, 2024
@lorenzoaiello lorenzoaiello merged commit 5386d65 into slack-go:master Aug 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants