Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: init v19 release and backport v20 PRs #386

Merged
merged 29 commits into from
Jul 9, 2024
Merged

slack-19.0: init v19 release and backport v20 PRs #386

merged 29 commits into from
Jul 9, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented May 30, 2024 •
edited
Loading

Description

This PR contains the typical hacks for a Slack release such as:

  1. CI runner updates to slackhq self-hosted
  2. Delete skip logic in tests (always run full CI)
  3. Private repo git-config for https://github.com/slackhq/vitess-addons
  4. CODEOWNERS setup for @slackhq/vitess-approvers
  5. Previous/downgrade-CI release set to https://github.com/slackhq/vitess/tree/slack-15.0
  6. A fix applied for issues downloading percona-xtrabackup-24 from Percona

Also all v20 backports we require we cherry picked, also 1 x to-be-upstreamed patch was forward-ported

v19 sideports

  1. [release-19.0] Add timeout to all the contexts used for RPC calls in vtorc (#15991) vitessio/vitess#16103
  2. [release-19.0] Upgrade the Golang version to go1.22.5 vitessio/vitess#16322

v20 Backports

  1. Load --grpc_auth_static_client_creds file once vitessio/vitess#15030
    • Stopped vtgate crashing in v14 upgrade
  2. Limit concurrent creation of healthcheck gRPC connections vitessio/vitess#15053
    • Stopped vtgate crashing in v14 upgrade
  3. Filter by keyspace earlier in tabletgateways WaitForTablets(...) vitessio/vitess#15347
  4. Make Durabler interface methods public vitessio/vitess#15548
    • Required by our custom Durability Policy

Internal Patches

  1. slack-vitess-r14.0.5: allow conn overrides in consul topo #111

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

timvaillancourt and others added 5 commits May 30, 2024 23:50
@github-actions github-actions bot added this to the v19.0.4 milestone May 30, 2024
@timvaillancourt
empty commit
1fdd1a5 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
force ci to run
efea4a0
@timvaillancourt
Update GH Action runners
563b839 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
test templates
e2a7d5e 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
set GH access token in build
a15511f 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
Fix reparent old tests
c719465 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
Remove CIs we don't need
0b0ae08 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
Remove CIs we don't need again
482f4c9 
Signed-off-by: Tim Vaillancourt <[email protected]>
@slackhq slackhq deleted a comment from codecov-commenter May 31, 2024
@slackhq slackhq deleted a comment from codecov-commenter May 31, 2024
@timvaillancourt
remove CI skip logic for upstream stuff
b8b8b61 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
CODEOWNERS
ba4be6c 
Signed-off-by: Tim Vaillancourt <[email protected]>
@github-actions github-actions bot added the Stale label Jul 1, 2024
@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented Jul 9, 2024

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@timvaillancourt
slack-vitess-r15.0.5: forward-port consul topo limits PR #111 (#297)
2dfc4d3 
* `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111)

* `slack-vitess-r14.0.5`: allow conn overrides in consul topo

Signed-off-by: Tim Vaillancourt <[email protected]>

* fix e2e test

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update flags tests that didn't exist in v14

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
@slackhq slackhq deleted a comment from codecov-commenter Jul 9, 2024
@slackhq slackhq deleted a comment from github-actions bot Jul 9, 2024
@timvaillancourt timvaillancourt changed the title slack-19.0: backport v20 PRs, set slack-15.0 as previous release slack-19.0: init v19 release and backport v20 PRs Jul 9, 2024
@vitess-bot @frouioui @timvaillancourt
[release-19.0] Upgrade the Golang version to go1.22.5 (vitessio#16322)
99a019f 
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: frouioui <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented Jul 9, 2024

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 @vitess-bot to sign the Salesforce Inc. Contributor License Agreement.

@timvaillancourt
merge conflict fixes
f90a960 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
make vtadmin_web_proto_types
06f0844 
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt marked this pull request as ready for review July 9, 2024 20:07
@timvaillancourt
Copy link
Member Author

Merging with these 6 x known downgrade failures (with slack-15.0) that will be resolved in follow-up PRs

Screenshot 2024-07-09 at 23 00 02

@timvaillancourt timvaillancourt merged commit 15ee54c into slack-19.0 Jul 9, 2024
192 of 199 checks passed
@timvaillancourt timvaillancourt deleted the bp-v20-prs-slack-19.0 branch July 9, 2024 21:01
@timvaillancourt timvaillancourt modified the milestones: v19.0.4, v19.0.5 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:missing slack-cherrypick upstream-backport An upstream backport v19 v20-backport
Projects
None yet
Milestone
v19.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @GuptaManan100 @vitess-bot