Fix first ready bug #401
Closed
Fix first ready bug #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug in
first_readywhere the builder only selects a target from one pool.We let the picker do the picking, by pushing down the list of ready subconns into the picker. The picker always returns the same subconn from that list, unless there's an error on an RPC, in which case the index is advanced and the next subconn is used. This is very similar to the round_robin implementation.
This has the advantage that RPC errors are detected and mitigated in-line, rather than waiting for service discovery to tell us about a change in the set of healthy subconns.
One improvement we should make is that the subconn is chosen randomly initially after every call to
Buildfor the same target; we should sort the list of conns by something stable.