Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] VReplication: Make Source Tablet Selection More Robust (#13582) #497

Open
wants to merge 6 commits into
base: slack-15.0
Choose a base branch
from

Conversation

makinje16
Copy link
Member

@makinje16 makinje16 commented Aug 29, 2024

Description

This PR backports vitessio#13582 in order to fix the NOT_FOUND errors we've seen on the CDC project during tablet failure on the streaming host.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

makinje16 and others added 4 commits August 29, 2024 11:25
* `txthrottler`: move `ThrottlerInterface` to `go/vt/throttler`, use `slices` pkg, add stats (vitessio#16248)

Signed-off-by: Tim Vaillancourt <[email protected]>

* revert to `reflect`

Signed-off-by: Tim Vaillancourt <[email protected]>

* Support passing filters to `discovery.NewHealthCheck(...)`

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go

Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>

* Address some PR suggestions

Signed-off-by: Tim Vaillancourt <[email protected]>

* PR ctx suggestion

Signed-off-by: Tim Vaillancourt <[email protected]>

* fix test

Signed-off-by: Tim Vaillancourt <[email protected]>

* simplify updateHealthCheckCells signature

Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix race in `replicationLagModule` of `go/vt/throttle`

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
@makinje16 makinje16 requested a review from a team as a code owner August 29, 2024 16:30
@github-actions github-actions bot added this to the v15.0.5 milestone Aug 29, 2024
@makinje16 makinje16 changed the title Backport upstream 13582 [test] [Backport] VReplication: Make Source Tablet Selection More Robust (#13582) Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants