Add merge task to handle existing trait definitions #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenbaker
approved these changes
May 31, 2024
haydenbaker
reviewed
May 31, 2024
| } | ||
|
|
||
| @trait(selector: "member") | ||
| string jsonName |
There was a problem hiding this comment.
nit: IMO, it would be better to name this something else, since jsonName is already a commonly used trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Updates the existing trait codegen plugin to handle cases where the user has both generated and hand-written traits. A new
mergeSpiFilestask is added that merges existing trait service provider files with the generated service provider file so all trait implementations included in the output JAR are correctly discovered.Testing
Added two new integration tests for trait modules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.