fix: Correct default zero-value for int enum shapes (#823)

* Fix zero-equivalent error correction default value given to int enum member in output that is required but does not have default trait. * Fix comment on RetryStrategyOptions initializer. * Change -1 to 0. --------- Co-authored-by: Sichan Yoo <[email protected]>
smithy-lang · Sep 13, 2024 · 9e614f2 · 9e614f2
1 parent 9115a71
commit 9e614f2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Sources/SmithyRetriesAPI/RetryStrategyOptions.swift b/Sources/SmithyRetriesAPI/RetryStrategyOptions.swift
@@ -45,7 +45,7 @@ public struct RetryStrategyOptions: Sendable {
 
     /// Creates a new set of retry strategy options
     /// - Parameters:
-    ///   - backoffStrategy: Determines the delay time before retrying.  Defaults to exponential backoff with a max limit.
+    ///   - backoffStrategy: Determines the delay time before retrying. For default behavior, use `ExponentialBackoffStrategy()`.
     ///   - maxRetriesBase: The number of times to retry the initial request.  Defaults to 2.
     ///   - availableCapacity: The number of available tokens in a retry quota.  Defaults to 500.
     ///   - maxCapacity: The max number of tokens in a retry quota.  Defaults to 500.

diff --git a/...ftware/amazon/smithy/swift/codegen/integration/serde/member/MemberShapeDecodeGenerator.kt b/...ftware/amazon/smithy/swift/codegen/integration/serde/member/MemberShapeDecodeGenerator.kt
@@ -164,7 +164,8 @@ open class MemberShapeDecodeGenerator(
         // If member is required but there isn't a default value, use zero-equivalents for error correction
         if (requiredTrait != null && defaultTrait == null) {
             return when (targetShape) {
-                is EnumShape, is IntEnumShape -> " ?? .sdkUnknown(\"\")"
+                is EnumShape -> " ?? .sdkUnknown(\"\")"
+                is IntEnumShape -> " ?? .sdkUnknown(0)"
                 is StringShape -> {
                     // Enum trait is deprecated but many services still use it in their models
                     if (targetShape.hasTrait<EnumTrait>()) {