Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add default trait support #803

Merged
merged 24 commits into from
Sep 6, 2024
Merged

feat: Add default trait support #803

merged 24 commits into from
Sep 6, 2024

Commits on Aug 28, 2024

  1. Add default value handling to SwiftSymbolProvider.

    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0dc4736 View commit details
    Browse the repository at this point in the history

  2. Add default value handling for generating expected body when generati… 

    …ng expected HTTP response in protocol tests.
    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b779a3c View commit details
    Browse the repository at this point in the history

  3. Add more comprehensive default value handling for deserialization, al… 

    …so add error correction for server failing to send a required value in response by filling with zero or zero-equivalents.
    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    cd7bf76 View commit details
    Browse the repository at this point in the history

  4. Modify ShapeExt::defaultValue logic to handle an optional value havin… 

    …g a default value.
    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    266d1b4 View commit details
    Browse the repository at this point in the history

  5. Handle edgecase where floating point value has integer default value … 

    …given in trait.
    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    d2a7486 View commit details
    Browse the repository at this point in the history

  6. Provide zero-equivalent error correction default value for enums by u… 

    …sing .sdkUnknown case.
    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b5d8f8f View commit details
    Browse the repository at this point in the history

  7. Handle JSON number value equality with loosened restriction (JSON han… 

    …dles 2 and 2.0 the same, as numbers)
    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b9325f5 View commit details
    Browse the repository at this point in the history

  8. Add enum trait handling

    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    da6d9e8 View commit details
    Browse the repository at this point in the history

  9. Fix enum case name codegen for default value

    Sichan Yoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6135529 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Fix int enum value handling & address future Swift 6 error warning by… 

    … using Foundation.Data() to convert string to data. Use symbol's property bag to set flag for importing Data outside of SwiftSymbolProvider.
    Sichan Yoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    80bdb80 View commit details
    Browse the repository at this point in the history

  2. Refactor blob and document shape type default value codegen to reduce… 

    … duplication.
    Sichan Yoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c560e74 View commit details
    Browse the repository at this point in the history

  3. Use flag for importing Foundation.Data set by SwiftSymbolProvider (wh… 

    …en handling blob shape) and add import.
    Sichan Yoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9bcb4a0 View commit details
    Browse the repository at this point in the history

  4. Ktlint

    Sichan Yoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b811037 View commit details
    Browse the repository at this point in the history

  5. Refactor to use when{} as expression; return no default value instead… 

    … of throwing error in MemberShapeDecodeGenerator for null node case.
    Sichan Yoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ce6dcf3 View commit details
    Browse the repository at this point in the history

  6. ktlint

    Sichan Yoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9f187c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Address PR comments

    Sichan Yoo committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d8b9190 View commit details
    Browse the repository at this point in the history

  2. Address PR comments

    Sichan Yoo committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ddb5587 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat/default-trait-support

    @sichanyoo
    sichanyoo committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    573b725 View commit details
    Browse the repository at this point in the history

  4. Address PR comment

    Sichan Yoo committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f9d7eef View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge main into feat/default-trait-support branch.

    Sichan Yoo committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e73f0db View commit details
    Browse the repository at this point in the history

  2. Use closure to handle dependency import for the default value resolve… 

    …d by SwiftSymbolProvider at a later time when the resolved symbol gets used by SwiftWriter. Also, fix timestamp value handling and add logic for date-time case as well.
    Sichan Yoo committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    120940c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat/default-trait-support

    Sichan Yoo committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    71b8c93 View commit details
    Browse the repository at this point in the history

  4. ktlint

    Sichan Yoo committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    52716db View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge branch 'main' into feat/default-trait-support

    @sichanyoo
    sichanyoo committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    56cc412 View commit details
    Browse the repository at this point in the history