Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for space cover #919

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Sep 7, 2024

Working towards https://github.com/snapshot-labs/workflow/issues/152

This PR adds support for returning the cover field in the space settings when requested

See snapshot-labs/snapshot.js#1055 for the corresponding write PR

@wa0x6e wa0x6e requested a review from ChaituVR September 7, 2024 09:47
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@wa0x6e wa0x6e marked this pull request as ready for review September 7, 2024 09:48
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 43c70a2 into master Sep 9, 2024
4 checks passed
@wa0x6e wa0x6e deleted the feat-add-support-for-space-cover branch September 9, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants