Prevent collection of uncollectable allocations
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the collector so that allocations with the uncollectable flag set are never considered garbage during sweeping. This allows for switching between collectable and uncollectable allocations during runtime.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like I was running these tests locally without one of the -D flags, let me see what's going on. |
|
Any luck? |
|
I've got a new PR that I'm going to raise that addresses this and includes the logic around moving between allocation types during finaliser elision. Without this, some invariants don't hold and the assertions don't make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the collector so that allocations with the uncollectable flag set are never considered garbage during sweeping.
This allows for switching between collectable and uncollectable allocations during runtime.