Simplify whitespace trimming #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect. Thanks! Please squash. |
fm previously had three whitespace options: ignore_leading_whitespace,
ignore_trailing_whitespace, ignore_surrounding_blank_lines. I
implemented those and each time I had to read the documentation three
times to work out which was which. Even worse, the *trailing* whitespace
search didn't quite work correctly.
This commit radically simplifies things:
1. There is now one option for "trimming whitespace". In its default
option, it "does what most people want (TM)". Anyone who sets it to
false will presumably be willing to be very careful in the tests
they write.
2. This allows the main searching loop to be substantially simplified.
So, in summary this commit: is more correct than before and simpler than
before. It does break backwards compatibility, but for a set of options
that I doubt anyone actually used much, if at all.
This has become so voluminous that, in the main matching loop, it's distracting.
ltratt
force-pushed
the
simplify_whitespace_trimming
branch
from
2244c60
to
7550a0f
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of this PR is in 98e3fce. Hopefully the commit message explains what it's doing well! ab150bf is a tidy-up after the fact.
Notice that this PR is a breaking change: but, arguably,
..~was also a breaking change, so we've probably got a "two breaking changes for the price of one release" situation, which could be worse.