Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve signal setter type for code completion of string literal unions. #2297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Huliiiiii
Copy link

Summary

Improve signal setter type for code completion of string literal unions.

How did you test this change?

Reorder overload signatures

type setterNew<in out T> = {
    <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
    <U extends T>(
        ...args: undefined extends T ? [] : [value: (prev: T) => U]
    ): undefined extends T ? undefined : U
    <U extends T>(value: Exclude<U, Function>): U
    <U extends T>(value: (prev: T) => U): U

}

type SetterOld<in out T> = {
  <U extends T>(...args: undefined extends T ? [] : [value: (prev: T) => U]): undefined extends T
    ? undefined
    : U;
  <U extends T>(value: (prev: T) => U): U;
  <U extends T>(value: Exclude<U, Function>): U;
  <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
};


type strUnion = "foo" | "bar"

const setterNew: setterNew<strUnion> = (x) => x
const setterOld: SetterOld<strUnion> = (x) => x

setterNew() // completion: "foo" | "bar"
setterNew(x => "") // completion: "foo" | "bar"
// We can all get completion
setterOld() // completion: none
setterOld(x => "") // completion: "foo" | "bar"
// We cant get completionon first function

typescript playground

Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: ee8b9eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant