AttendanceCodeDialog 구현 #852
Open
+282
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: implement NewAttendanceActivity * feat: implement NewAttendanceViewModel * chore: add compose-lifecycle dependency * feat: define AttendanceAction * feat: implement screens * feat: use SoptTheme in designsystem * chore: data class -> class로 변경 * chore: 람다 프로퍼티 이름 명시 * chore: SoptTheme darkTheme 기본값 사용 * chore: 필요없는 함수 제거 * chore: 구현 안 된 함수에 TODO 삽입 * chore: 동작하지 않는 Preview 제거 * chore: AttendanceAction 내 뷰모델 참조 제거 * chore: code format 변경
|
giovannijunseokim
changed the title
giovannijunseokim
changed the title
giovannijunseokim
changed the title
l2hyunwoo
reviewed
Sep 15, 2024
Comment on lines
+34
to
+35
| codes: List<String>, | ||
| inputCodes: List<String?>, |
l2hyunwoo
reviewed
Sep 15, 2024
| AttendanceCodeCardList( | ||
| codes = inputCodes, | ||
| onTextChange = {}, | ||
| onTextFieldFull = {}) |
There was a problem hiding this comment.
Suggested change
| onTextFieldFull = {}) | |
| onTextFieldFull = {} | |
| ) |
l2hyunwoo
reviewed
Sep 15, 2024
| } | ||
| Spacer(modifier = Modifier.height(32.dp)) | ||
| Button( | ||
| onClick = { /*TODO*/ }, |
There was a problem hiding this comment.
넵 요 부분 뷰모델 짜면서 넣어줄게요!
l2hyunwoo
reviewed
Sep 15, 2024
Comment on lines
+28
to
+32
| if (newText.length < textMaxLength) { | ||
| onTextChange(newText) | ||
| } else { | ||
| onTextFieldFull() | ||
| } |
There was a problem hiding this comment.
이거 텍스트 복붙해서 붙이는 경우에 이미 한글자 이상 입력한 상황에서는 아예 안 붙여지지 않나요?
leeeyubin
approved these changes
Sep 15, 2024
Comment on lines
+19
to
+25
| Row(modifier = modifier) { | ||
| repeat(codes.size) { index -> | ||
| AttendanceCodeCard( | ||
| text = codes[index] ?: "", | ||
| onTextChange = onTextChange, | ||
| onTextFieldFull = onTextFieldFull | ||
| ) |
There was a problem hiding this comment.
아하 이렇게 단순 반복되는 작업은 repeat를 사용해서 나타낼 수 있군요!
There was a problem hiding this comment.
수가 고정된 경우는 그냥 LazyRow 쓰는 거나 저거나 별 차이 없을거에요
l2hyunwoo
reviewed
Sep 18, 2024
| } else { | ||
| onTextFieldFull() | ||
| } | ||
| }, modifier = modifier |
There was a problem hiding this comment.
Suggested change
| }, modifier = modifier | |
| }, | |
| modifier = modifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?
출석 화면 리팩토링 중, AttendanceCodeDialog에 관한 중간 PR입니다.
Reference
코드에 관한 질문? 지적? 환영합니다.
