feat: separate Compressor and Decompressor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Aug 16, 2024
| @@ -7,6 +7,9 @@ license = "Apache-2.0" | |||
| repository = "https://github.com/spiraldb/fsst" | |||
| edition = "2021" | |||
|
|
|||
| [lib] | |||
| name = "fsst" | |||
There was a problem hiding this comment.
nicer than typing use fsst_rs::...
a10y
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of implementing the vortex
FSSTArray, we should separate out the data for compression (symbol table, hash table, codes_twobyte vector) and decompression (just the symbol table).This PR separates the previous
SymbolTabletype into two types, aCompressorand aDecompressor<'a>. A Compressor can be trained on a sample text, as before, but it does not have decompression methods. Those are now on a newDecompressortype. Decompressors can either be built directly from a Compressor, or you can build one by directly wrapping a&[Symbol]. Compressors allow slice access to the symbol table as well, e.g. for serialization