since no longer in backticks, can remove replacing backticks

spowelljr · May 10, 2024 · acd2085 · acd2085
1 parent c213f42
commit acd2085
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/hack/update/cilium_version/update_cilium_version.go b/hack/update/cilium_version/update_cilium_version.go
@@ -63,10 +63,6 @@ func main() {
 	re = regexp.MustCompile(`# Source: cilium\/templates\/hubble\/tls-helm\/server-secret\.yaml(\n.*?)+---\n`)
 	yaml = re.ReplaceAllString(yaml, "")
 
-	// Replace backticks with single-quotes as the entire YAML is enclosed in backticks and will break
-	re = regexp.MustCompile("`")
-	yaml = re.ReplaceAllString(yaml, "'")
-
 	// Replace `cluster-pool-ipv4-cidr` with PodSubnet template
 	re = regexp.MustCompile(`10\.0\.0\.0\/8`)
 	yaml = re.ReplaceAllString(yaml, "{{ .PodSubnet }}")

diff --git a/pkg/minikube/cni/cilium.go b/pkg/minikube/cni/cilium.go
@@ -27,10 +27,11 @@ import (
 	"k8s.io/minikube/pkg/minikube/config"
 )
 
+// Generated by running `make update-cilium-version`
+//
 //go:embed cilium.yaml
 var ciliumYaml string
 
-// Generated by running `make update-cilium-version`
 var ciliumTmpl = template.Must(template.New("name").Parse(ciliumYaml))
 
 // Cilium is the Cilium CNI manager

diff --git a/pkg/minikube/cni/cilium.yaml b/pkg/minikube/cni/cilium.yaml
@@ -409,7 +409,7 @@ rules:
 - apiGroups:
   - ""
   resources:
-  # to perform the translation of a CNP that contains 'ToGroup' to its endpoints
+  # to perform the translation of a CNP that contains `ToGroup` to its endpoints
   - services
   - endpoints
   verbs: