Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful/StopImmediate shutdown #167

Open
sobychacko opened this issue Oct 19, 2022 · 0 comments
Open

Graceful/StopImmediate shutdown #167

sobychacko opened this issue Oct 19, 2022 · 0 comments
Labels
type: improvement An improvement of implementation of existing feature
Milestone
Backlog

Comments

@sobychacko
Copy link
Collaborator

sobychacko commented Oct 19, 2022 •
edited by onobc
Loading

What is the implication of this interrupt if the batch receive is in the middle of a batch of records? I understand the need for this when the timeout is high - but it also feels like maybe this would be an operation we did when the user asked to "stopImmediately" vs. "stopGracefully". Does this need to be included in this proposal or added when if we add a stopImmediately/Gracefully feature?

Either way, a comment would help understand the purpose of the interrupt.

Originally posted by @onobc in #162 (comment)
@sobychacko sobychacko mentioned this issue Oct 19, 2022
Closed
@sobychacko sobychacko added this to the 1.0.0 milestone Dec 15, 2022
@onobc onobc removed this from the 1.0.0 milestone Jan 11, 2023
@onobc onobc added type: feature A new feature or enhacement type: improvement An improvement of implementation of existing feature and removed type: feature A new feature or enhacement labels Nov 23, 2023
@onobc onobc added this to the Backlog milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: improvement An improvement of implementation of existing feature
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@sobychacko @onobc