Consumer restart causes duplicate messages #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
requested changes
Oct 13, 2022
There was a problem hiding this comment.
Nice fix @sobychacko ! I have left some minor suggestions / questions.
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/test/java/org/springframework/pulsar/core/ConsumerAcknowledgmentTests.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/test/java/org/springframework/pulsar/core/ConsumerAcknowledgmentTests.java
Outdated
Show resolved
Hide resolved
...pulsar/src/test/java/org/springframework/pulsar/observation/ObservationIntegrationTests.java
Show resolved
Hide resolved
...est/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainerTests.java
Show resolved
Hide resolved
spring-pulsar/src/test/java/org/springframework/pulsar/core/ConsumerAcknowledgmentTests.java
Show resolved
Hide resolved
When we stop the consumer, there is a race condition that forces the messages to not get acknowledged. This results in duplicate messages on the restart of the consumer. This PR addresses the issue by waiting for the consumer thread to complete before stopping the consumer. Resolves spring-projects#161
This was referenced Oct 19, 2022
onobc
reviewed
Oct 20, 2022
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Show resolved
Hide resolved
onobc
approved these changes
Oct 20, 2022
|
Closed via 2360a9d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we stop the consumer, there is a race condition that forces the messages to not get acknowledged. This results in duplicate messages on the restart of the consumer.
This PR addresses the issue by waiting for the consumer thread to complete before stopping the consumer.
Resolves #161