Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer cleanup in tests #168

Closed
sobychacko opened this issue Oct 19, 2022 · 1 comment
Closed

Consumer cleanup in tests #168

sobychacko opened this issue Oct 19, 2022 · 1 comment
Milestone
0.1.0

Comments

@sobychacko
Copy link
Collaborator 

    So this reminders me, in all of the consumer tests we close/stop/cleanup at the end of a **successful** test - but not during a failed one.

I don't think we need to fix that in this PR, but do you mind adding an issue for us to cleanup properly so we don't forget to come back to this?

Originally posted by @onobc in #162 (comment)
@sobychacko sobychacko mentioned this issue Oct 19, 2022
Closed
@sobychacko
Copy link
Collaborator Author

Closing this issue as this is not critical, and we are cleaning up many such tests.

@onobc onobc added this to the 0.1.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@sobychacko @onobc