Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report download #235

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

pmcelhaney
Copy link

@pmcelhaney pmcelhaney commented Oct 15, 2018

This PR adds a "CSV" button in the top right corner of the summary view. Clicking the button downloads the results in a CSV file.

The code needs to be cleaned up and I haven't thoroughly tested yet, but I want to go ahead and get this out there so that I can start collecting feedback.

Issue #111

}



Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole section needs to be deleted.

@@ -9,6 +9,7 @@ _global.translation['en'] = {
,"auditor_select_types" : 'Select the types of issues to include in the report'
,"auditor_home" : 'Home'
,"auditor_view_report" : 'View Report'
,"auditor_download_report": 'Download Report'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go. I ended up making the label "CSV" which is language-independent.

* Runs the sniffs and downloads the results to a text file
*
*/
_global.downloadHTMLCS = function () {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be part of the HTMLCS object.

@gsherwood
Copy link
Member

Just a note that the main developer on this project is on leave for the next several weeks, so PRs will be stalled.

@ironikart
Copy link
Contributor

I've put this into branch 'pmcelhaney-report-download' for now with a few changes. Will look at a merge after more testing and confirmation of the location we would add the button to download (It looks ok where it is imho, but visually it doesn't look clickable so I'll get some input from other colleagues first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants