Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't depend on external files #1162

Merged
merged 10 commits into from
Jun 22, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 15, 2023

Related Issue(s):

Description:

The vast majority of these changes have to do with validation so they might not be necessary if

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell
Copy link
Member Author

jsignell commented Jun 15, 2023

Ok so apparently the cassettes depend on whether urllib3 is installed or not 🤦

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (f9e5bd6) 91.99% compared to head (646d21e) 91.99%.

❗ Current head 646d21e differs from pull request most recent head d6913c2. Consider uploading reports for the commit d6913c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files          51       51              
  Lines        6795     6792       -3     
  Branches     1000     1000              
==========================================
- Hits         6251     6248       -3     
  Misses        368      368              
  Partials      176      176              
Impacted Files Coverage Δ
pystac/validation/local_validator.py 95.23% <100.00%> (-0.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsignell jsignell marked this pull request as ready for review June 22, 2023 14:31
@jsignell jsignell requested a review from gadomski June 22, 2023 14:31
@jsignell jsignell self-assigned this Jun 22, 2023
@jsignell jsignell added this pull request to the merge queue Jun 22, 2023
Merged via the queue into stac-utils:main with commit 568c3af Jun 22, 2023
20 checks passed
@jsignell jsignell deleted the no-network-tests branch June 22, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid network calls in tests suite Make sure all test data is local
2 participants