-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests don't depend on external files #1162
Conversation
Ok so apparently the cassettes depend on whether urllib3 is installed or not 🤦 |
8b24dd5
to
4065b27
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
- Coverage 91.99% 91.99% -0.01%
==========================================
Files 51 51
Lines 6795 6792 -3
Branches 1000 1000
==========================================
- Hits 6251 6248 -3
Misses 368 368
Partials 176 176
☔ View full report in Codecov by Sentry. |
Related Issue(s):
Description:
The vast majority of these changes have to do with validation so they might not be necessary if
PR Checklist:
pre-commit
hooks pass locallyscripts/test
)