Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faulty mypy annotation #1166

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jpolchlo
Copy link
Contributor

@jpolchlo jpolchlo commented Jun 21, 2023

Description:
There's a lint error generated with newer mypy versions. This fix removes the erring annotation.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c871b36) 92.03% compared to head (39fc01e) 92.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          49       49           
  Lines        6658     6658           
  Branches      984      984           
=======================================
  Hits         6128     6128           
  Misses        356      356           
  Partials      174      174           
Impacted Files Coverage Δ
pystac/validation/__init__.py 79.36% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jpolchlo jpolchlo requested a review from pjhartzell June 21, 2023 13:55
@jpolchlo jpolchlo added this pull request to the merge queue Jun 21, 2023
@jpolchlo jpolchlo mentioned this pull request Jun 21, 2023
5 tasks
Merged via the queue into stac-utils:main with commit 23e75ca Jun 21, 2023
22 checks passed
@jpolchlo jpolchlo deleted the fix/mypy-ignore-error branch June 21, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants