Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests fail on warning #1173

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Make tests fail on warning #1173

merged 3 commits into from
Jun 26, 2023

Conversation

jsignell
Copy link
Member

Related Issue(s):

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell jsignell requested a review from gadomski June 23, 2023 20:32
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (80201b7) 91.99% compared to head (48fa5b8) 91.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          51       51           
  Lines        6792     6792           
  Branches     1000     1000           
=======================================
  Hits         6248     6248           
  Misses        368      368           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsignell jsignell self-assigned this Jun 23, 2023
@jsignell
Copy link
Member Author

Should fail until #1172 is merged

@gadomski gadomski enabled auto-merge June 23, 2023 21:27
@gadomski gadomski added this to the 1.8 milestone Jun 26, 2023
@gadomski
Copy link
Member

gadomski commented Jun 26, 2023

@jsignell pushed onto your branch to use the (previously broken) pyproject.toml config, lmk what you think. Tested it locally w/ a made-up deprecation warning and it worked.

@gadomski gadomski added this pull request to the merge queue Jun 26, 2023
Merged via the queue into stac-utils:main with commit 53fb152 Jun 26, 2023
22 checks passed
@jsignell jsignell deleted the werror branch June 26, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants