feat(mempool): add l2_gas_price support in BlockHeader

[TzahiTaub]

This change is 

[TzahiTaub]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(mempool): add l2_gas_price support in BlockHeader #652 👈
• feat(execution): add l2_gas_price to FeeEstimation #644
• chore(execution): add l2_gas_price to PendingData #643
• feat(starknet_api, protobuf): add l2_gas_price to block header #641
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @TzahiTaub and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (da4fbcf) to head (38d02d8).

Files with missing lines	Patch %	Lines
crates/gateway/src/rpc_objects.rs	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@                                      Coverage Diff                                      @@
##           tzahi/papyrus_execution/add_l2_gas_price_to_FeeEstimation     #652      +/-   ##
=============================================================================================
- Coverage                                                      74.26%   74.25%   -0.02%     
=============================================================================================
  Files                                                            359      359              
  Lines                                                          36249    36262      +13     
  Branches                                                       36249    36262      +13     
=============================================================================================
+ Hits                                                           26920    26925       +5     
- Misses                                                          7195     7202       +7     
- Partials                                                        2134     2135       +1     

Flag	Coverage Δ
	74.25% <80.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 10 of 10 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ShahakShama and @TzahiTaub)

---

crates/papyrus_rpc/src/v0_8/api/test.rs line 598 at r3 (raw file):

    };
    let pending_l2_gas_price =
        GasPricePerToken { price_in_wei: GasPrice(0), price_in_fri: GasPrice(0) };

please refrain from using zero as a price... why not randomize, like with the pending_l1_gas_price above?

Code quote:

price_in_wei: GasPrice(0), price_in_fri: GasPrice(0)

---

crates/papyrus_rpc/src/v0_8/api/test.rs line 787 at r3 (raw file):

    };
    let pending_l2_gas_price =
        GasPricePerToken { price_in_wei: GasPrice(0), price_in_fri: GasPrice(0) };

ditto

Code quote:

    let pending_l2_gas_price =
        GasPricePerToken { price_in_wei: GasPrice(0), price_in_fri: GasPrice(0) };

---

crates/papyrus_rpc/src/v0_8/api/test.rs line 976 at r3 (raw file):

    };
    let pending_l2_gas_price =
        GasPricePerToken { price_in_wei: GasPrice(0), price_in_fri: GasPrice(0) };

ditto

Code quote:

    let pending_l2_gas_price =
        GasPricePerToken { price_in_wei: GasPrice(0), price_in_fri: GasPrice(0) };

[yoavGrs]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware, @ShahakShama, and @TzahiTaub)

---

crates/papyrus_rpc/src/v0_8/api/test.rs line 598 at r3 (raw file):

Previously, dorimedini-starkware wrote…

please refrain from using zero as a price... why not randomize, like with the pending_l1_gas_price above?

The expected_pending_block is compared against a DeprecatedPendingBlock, that doesn't have a l2_gas_price field.

[dorimedini-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ShahakShama and @TzahiTaub)

---

crates/papyrus_rpc/src/v0_8/api/test.rs line 598 at r3 (raw file):

Previously, yoavGrs wrote…

The expected_pending_block is compared against a DeprecatedPendingBlock, that doesn't have a l2_gas_price field.

ah... gotcha

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)