feat(consensus): add locked_value to sm

[asmaastarkware]

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.34%. Comparing base (b0cfe82) to head (593bb05).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
.../sequencing/papyrus_consensus/src/state_machine.rs	84.61%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (593bb05). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (593bb05)
	3	1

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #733       +/-   ##
==========================================
- Coverage   74.18%   8.34%   -65.85%     
==========================================
  Files         359      71      -288     
  Lines       36240    8690    -27550     
  Branches    36240    8690    -27550     
==========================================
- Hits        26886     725    -26161     
- Misses       7220    7929      +709     
+ Partials     2134      36     -2098     

Flag	Coverage Δ
	8.34% <84.61%> (-65.85%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matan-starkware]

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)

---

-- commits line 2 at r1:
Split this into 2 separate PRs please.

Code quote:

- f0b06ce: feat(consensus): add locked_value to sm and valid_round to proposal

[matan-starkware]

Reviewed 3 of 11 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)

---

crates/sequencing/papyrus_consensus/src/state_machine_test.rs line 367 at r2 (raw file):

    wrapper.send_precommit(None, ROUND);
    assert_eq!(wrapper.next_event().unwrap(), StateMachineEvent::TimeoutPrecommit(ROUND));

We don't need to send a pure NIL quorum. A mixed quorum is enough.

Suggestion:

    assert_eq!(wrapper.next_event().unwrap(), StateMachineEvent::TimeoutPrecommit(ROUND));

[asmaastarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)

---

crates/sequencing/papyrus_consensus/src/state_machine_test.rs line 367 at r2 (raw file):

Previously, matan-starkware wrote…

We don't need to send a pure NIL quorum. A mixed quorum is enough.

we want NIL quorum to advance to the next round

[matan-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

[matan-starkware]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)