Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mempool_infra): add serde utils #907

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Sep 22, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.05%. Comparing base (b0cfe82) to head (84f37c0).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
crates/mempool_infra/src/serde_utils.rs 90.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (84f37c0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b0cfe82) HEAD (84f37c0)
3 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #907       +/-   ##
===========================================
- Coverage   74.18%   19.05%   -55.14%     
===========================================
  Files         359      114      -245     
  Lines       36240    13088    -23152     
  Branches    36240    13088    -23152     
===========================================
- Hits        26886     2494    -24392     
- Misses       7220    10265     +3045     
+ Partials     2134      329     -1805     
Flag Coverage Δ
19.05% <90.00%> (-55.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/93bc459d branch from 56b3c96 to 7e134f8 Compare September 22, 2024 07:29
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.347 ms 66.433 ms 66.536 ms]
change: [-7.9029% -4.5420% -1.6277%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/93bc459d branch from 7e134f8 to a66db70 Compare September 22, 2024 07:55
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch from 84ffbda to d0c2246 Compare September 22, 2024 08:40
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/93bc459d branch 2 times, most recently from b18f8fc to 9b3c9c2 Compare September 22, 2024 10:29
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 branch from d0c2246 to 98ecb4e Compare September 22, 2024 10:29
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.417 ms 66.505 ms 66.606 ms]
change: [-9.8270% -6.2818% -3.0988%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/7e0d8402 to main September 22, 2024 11:09
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/93bc459d branch from 9b3c9c2 to 74e4436 Compare September 22, 2024 11:09
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.924 ms 67.017 ms 67.117 ms]
change: [-9.0517% -5.5412% -2.4838%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/mempool_infra/src/serde_utils.rs line 16 at r1 (raw file):

}

impl<T> SerdeWrapper<T>

Change to BincodeSerdeWrapper

Code quote:

SerdeWrapper

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/93bc459d branch from 74e4436 to 5c7105f Compare September 24, 2024 08:24
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/remote_connetion/93bc459d branch from 5c7105f to 84f37c0 Compare September 24, 2024 08:28
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)


crates/mempool_infra/src/serde_utils.rs line 16 at r1 (raw file):

Previously, lev-starkware wrote…

Change to BincodeSerdeWrapper

Done.

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.833 ms 67.162 ms 67.755 ms]
change: [-8.6013% -5.2435% -2.3599%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants