-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mempool_infra): add serde utils #907
feat(mempool_infra): add serde utils #907
Conversation
192301f
to
56b3c96
Compare
faf3cfd
to
61d5b64
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
===========================================
- Coverage 74.18% 19.05% -55.14%
===========================================
Files 359 114 -245
Lines 36240 13088 -23152
Branches 36240 13088 -23152
===========================================
- Hits 26886 2494 -24392
- Misses 7220 10265 +3045
+ Partials 2134 329 -1805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
56b3c96
to
7e134f8
Compare
Benchmark movements: |
7e134f8
to
a66db70
Compare
84ffbda
to
d0c2246
Compare
b18f8fc
to
9b3c9c2
Compare
d0c2246
to
98ecb4e
Compare
Benchmark movements: |
9b3c9c2
to
74e4436
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/mempool_infra/src/serde_utils.rs
line 16 at r1 (raw file):
} impl<T> SerdeWrapper<T>
Change to BincodeSerdeWrapper
Code quote:
SerdeWrapper
74e4436
to
5c7105f
Compare
commit-id:93bc459d
5c7105f
to
84f37c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)
crates/mempool_infra/src/serde_utils.rs
line 16 at r1 (raw file):
Previously, lev-starkware wrote…
Change to BincodeSerdeWrapper
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
✓ Commit merged in pull request #904 |
Stack:
This change is