-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(node): users pass the prefix for splitting config args #925
base: matan/consensus/m5/run_simulation_setup_artifact_dirs
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @matan-starkware and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## matan/consensus/m5/run_simulation_setup_artifact_dirs #925 +/- ##
========================================================================================
- Coverage 8.31% 7.22% -1.10%
========================================================================================
Files 71 190 +119
Lines 8702 26904 +18202
Branches 8702 26904 +18202
========================================================================================
+ Hits 724 1945 +1221
- Misses 7942 24768 +16826
- Partials 36 191 +155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
258a4c0
to
512b6da
Compare
97205f7
to
70dd8cd
Compare
This change is