Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): users pass the prefix for splitting config args #925

Open
wants to merge 1 commit into
base: matan/consensus/m5/run_simulation_setup_artifact_dirs
Choose a base branch
from

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 22, 2024

This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review September 22, 2024 12:15
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 7.22%. Comparing base (512b6da) to head (70dd8cd).

Files with missing lines Patch % Lines
crates/papyrus_node/src/bin_utils.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           matan/consensus/m5/run_simulation_setup_artifact_dirs    #925      +/-   ##
========================================================================================
- Coverage                                                   8.31%   7.22%   -1.10%     
========================================================================================
  Files                                                         71     190     +119     
  Lines                                                       8702   26904   +18202     
  Branches                                                    8702   26904   +18202     
========================================================================================
+ Hits                                                         724    1945    +1221     
- Misses                                                      7942   24768   +16826     
- Partials                                                      36     191     +155     
Flag Coverage Δ
7.22% <0.00%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 258a4c0 to 512b6da Compare September 24, 2024 09:09
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_configs_split_args_prefix branch from 97205f7 to 70dd8cd Compare September 24, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants