-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: blockifier regression test add get fee token addresses #948
base: aviv/regression_test_add_get_blok_info
Are you sure you want to change the base?
build: blockifier regression test add get fee token addresses #948
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AvivYossef-starkware and the rest of your teammates on Graphite |
6ca2811
to
d3ba818
Compare
4e49777
to
5545b16
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aviv/regression_test_add_get_blok_info #948 +/- ##
==========================================================================
- Coverage 68.40% 60.40% -8.01%
==========================================================================
Files 128 125 -3
Lines 12990 16384 +3394
Branches 12990 16384 +3394
==========================================================================
+ Hits 8886 9896 +1010
- Misses 3640 5696 +2056
- Partials 464 792 +328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d3ba818
to
5b3d719
Compare
5545b16
to
a0fce57
Compare
a0fce57
to
d56d948
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)
crates/papyrus_execution/src/lib.rs
line 94 at r3 (raw file):
const STARKNET_VERSION_O_13_1: &str = "0.13.1"; const STARKNET_VERSION_O_13_2: &str = "0.13.2"; pub const STRK_FEE_CONTRACT_ADDRESS: &str =
Blocked until approved by @dorimedini-starkware.
Code quote:
pub
crates/papyrus_execution/src/lib.rs
line 96 at r3 (raw file):
pub const STRK_FEE_CONTRACT_ADDRESS: &str = "0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d"; pub const ETH_FEE_CONTRACT_ADDRESS: &str =
Blocked until approved by @dorimedini-starkware.
Code quote:
pub
This change is