Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: blockifier regression test add get fee token addresses #948

Open
wants to merge 1 commit into
base: aviv/regression_test_add_get_blok_info
Choose a base branch
from

Conversation

AvivYossef-starkware
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware commented Sep 23, 2024

This change is Reviewable

Copy link
Contributor Author

AvivYossef-starkware commented Sep 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on Graphite Graphite

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.260 ms 66.334 ms 66.421 ms]
change: [-8.5810% -5.1834% -2.1504%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high severe

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.40%. Comparing base (5b3d719) to head (d56d948).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           aviv/regression_test_add_get_blok_info     #948      +/-   ##
==========================================================================
- Coverage                                   68.40%   60.40%   -8.01%     
==========================================================================
  Files                                         128      125       -3     
  Lines                                       12990    16384    +3394     
  Branches                                    12990    16384    +3394     
==========================================================================
+ Hits                                         8886     9896    +1010     
- Misses                                       3640     5696    +2056     
- Partials                                      464      792     +328     
Flag Coverage Δ
60.40% <ø> (-8.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/regression_test_add_get_fee_token_addresses branch from a0fce57 to d56d948 Compare September 23, 2024 12:27
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [67.015 ms 67.080 ms 67.156 ms]
change: [-8.2939% -4.9883% -2.1362%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

Copy link
Contributor

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)


crates/papyrus_execution/src/lib.rs line 94 at r3 (raw file):

const STARKNET_VERSION_O_13_1: &str = "0.13.1";
const STARKNET_VERSION_O_13_2: &str = "0.13.2";
pub const STRK_FEE_CONTRACT_ADDRESS: &str =

Blocked until approved by @dorimedini-starkware.

Code quote:

pub

crates/papyrus_execution/src/lib.rs line 96 at r3 (raw file):

pub const STRK_FEE_CONTRACT_ADDRESS: &str =
    "0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d";
pub const ETH_FEE_CONTRACT_ADDRESS: &str =

Blocked until approved by @dorimedini-starkware.

Code quote:

pub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants