Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mempool): remove AccountNonce struct #965

Open
wants to merge 1 commit into
base: ayelet/mempool/account-state-refactor/merge-account-nonce-into-account-state
Choose a base branch
from

Conversation

ayeletstarkware
Copy link
Contributor

@ayeletstarkware ayeletstarkware commented Sep 23, 2024

Part of a larger refactor.
Starting point:
Two separate structs:

  • AccountState (contains a nonce field)
  • Account (contains sender_address and AccountState)

Target:
Merge into one struct, AccountState, containing two fields: sender_address and account_nonce.

Current state:

  • AccountState (contains sender_address and nonce)

Please start by reviewing the mempool_types.rs file first.

Stack of PRs:

  1. refactor(mempool): rename account state to account nonce refactor(mempool): rename account state to account nonce #957
  2. refactor(mempool): rename account to account state refactor(mempool): rename account to account state #959
  3. refactor(mempool): merge AccountNonce into AccountState refactor(mempool): merge AccountNonce into AccountState #963
  4. refactor(mempool): remove AccountNonce struct refactor(mempool): remove AccountNonce struct #965 <-- you're here

This change is Reviewable

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.01%. Comparing base (d50eda9) to head (8e86f4a).

Additional details and impacted files
@@                                                Coverage Diff                                                @@
##           ayelet/mempool/account-state-refactor/merge-account-nonce-into-account-state     #965       +/-   ##
=================================================================================================================
- Coverage                                                                         28.29%   15.01%   -13.29%     
=================================================================================================================
  Files                                                                               119       34       -85     
  Lines                                                                             12440     2758     -9682     
  Branches                                                                          12440     2758     -9682     
=================================================================================================================
- Hits                                                                               3520      414     -3106     
+ Misses                                                                             8673     2326     -6347     
+ Partials                                                                            247       18      -229     
Flag Coverage Δ
15.01% <100.00%> (-13.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant