Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mempool_infra): create designated server and component errors, apply throughout #974

Open
wants to merge 1 commit into
base: pr/Itay-Tsabary-Starkware/tsabary/node_main/d1d73c87
Choose a base branch
from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Sep 24, 2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 36.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 18.98%. Comparing base (0f6dad5) to head (b6e7ed7).

Files with missing lines Patch % Lines
...fra/src/component_server/local_component_server.rs 50.00% 2 Missing and 1 partial ⚠️
crates/mempool_node/src/servers.rs 0.00% 3 Missing ⚠️
crates/http_server/src/http_server.rs 0.00% 2 Missing ⚠️
...ra/src/component_server/remote_component_server.rs 66.66% 2 Missing ⚠️
crates/mempool_infra/src/errors.rs 0.00% 2 Missing ⚠️
crates/consensus_manager/src/consensus_manager.rs 0.00% 1 Missing ⚠️
crates/gateway/src/gateway.rs 0.00% 1 Missing ⚠️
...fra/src/component_server/empty_component_server.rs 50.00% 0 Missing and 1 partial ⚠️
crates/mempool_p2p/src/receiver/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           pr/Itay-Tsabary-Starkware/tsabary/node_main/d1d73c87     #974      +/-   ##
========================================================================================
+ Coverage                                                 15.99%   18.98%   +2.99%     
========================================================================================
  Files                                                        48      212     +164     
  Lines                                                      3552    21963   +18411     
  Branches                                                   3552    21963   +18411     
========================================================================================
+ Hits                                                        568     4169    +3601     
- Misses                                                     2950    17523   +14573     
- Partials                                                     34      271     +237     
Flag Coverage Δ
18.98% <36.00%> (+2.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant