Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hrpsys_ros_bridge_tutorials] Euslisp interface of HIRONXJSK for latest hrpsys #563

Merged
merged 27 commits into from
Apr 21, 2020

Conversation

pazeshun
Copy link
Contributor

Depends on https://github.com/start-jsk/rtmros_hrp2/pull/507
Updated version of #549

Thanks to updating hrpsys inside HIRONXJSK (see fkanehiro/hrpsys-base#1283), we can delete special code for old hrpsys.

@pazeshun pazeshun force-pushed the hironxjsk-interface-latest-hrpsys branch from d4730ec to 4b3e5f8 Compare November 27, 2019 11:52
@pazeshun
Copy link
Contributor Author

@Affonso-Gui Could you add document to hand interface methods?

pazeshun and others added 26 commits January 29, 2020 18:48
Old hrpsys in HIRONX itself has no way to load file of force moment offset param, so we do that with Euslisp
Because hironx has two types of joint_states on one topic: whole body and hand
@pazeshun pazeshun force-pushed the hironxjsk-interface-latest-hrpsys branch from 4b3e5f8 to 6b85314 Compare January 29, 2020 09:48
@Affonso-Gui
Copy link
Member

@pazeshun Created PR at pazeshun#3

@pazeshun
Copy link
Contributor Author

@pazeshun Created PR at pazeshun#3

Thanks. Merged.

@pazeshun
Copy link
Contributor Author

pazeshun commented Jan 31, 2020

https://github.com/start-jsk/rtmros_hrp2/pull/507 is already merged.
No more "W4U (wait for upstream)".

@pazeshun pazeshun changed the title [W4U][hrpsys_ros_bridge_tutorials] Euslisp interface of HIRONXJSK for latest hrpsys [hrpsys_ros_bridge_tutorials] Euslisp interface of HIRONXJSK for latest hrpsys Jan 31, 2020
@pazeshun
Copy link
Contributor Author

@YoheiKakiuchi Could you review & merge this?

@pazeshun
Copy link
Contributor Author

pazeshun commented Mar 3, 2020

@YoheiKakiuchi Kindly ping

2 similar comments
@pazeshun
Copy link
Contributor Author

@YoheiKakiuchi Kindly ping

@pazeshun
Copy link
Contributor Author

pazeshun commented Apr 7, 2020

@YoheiKakiuchi Kindly ping

Copy link
Member

@YoheiKakiuchi YoheiKakiuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoheiKakiuchi
Copy link
Member

@k-okada Please merge this PR

@pazeshun
Copy link
Contributor Author

pazeshun commented Apr 9, 2020

@k-okada Could you merge this?
Sorry for rushing you, but this PR is required for the online one-week project.

@pazeshun
Copy link
Contributor Author

@k-okada kindly ping

1 similar comment
@pazeshun
Copy link
Contributor Author

@k-okada kindly ping

@k-okada k-okada merged commit 34cd4d0 into start-jsk:master Apr 21, 2020
@pazeshun
Copy link
Contributor Author

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants