Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Fix CP nav ordering for when preferences are stored in JSON SQL columns #10809

Open
wants to merge 21 commits into
base: 5.x
Choose a base branch
from
Open

[5.x] Fix CP nav ordering for when preferences are stored in JSON SQL columns #10809

wants to merge 21 commits into from

Commits on Sep 17, 2024

  1. From now on, we reject all @inherit items when minifying.

    @jesseleite
    jesseleite committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    596320b View commit details
    Browse the repository at this point in the history

  2. Rename method.

    @jesseleite
    jesseleite committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fe04239 View commit details
    Browse the repository at this point in the history

  3. Rework @inherit minification at each level of nav.

    @jesseleite
    jesseleite committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    084b1fa View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Save explicit array to reorder instead of true bool.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    355cda1 View commit details
    Browse the repository at this point in the history

  2. Return minimum count for use in reorder arrays.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5c85884 View commit details
    Browse the repository at this point in the history

  3. Rename method and remove unused reorderedMinimums property.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    599e1b5 View commit details
    Browse the repository at this point in the history

  4. Remove unused params.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    332e46a View commit details
    Browse the repository at this point in the history

  5. Remove Top Level from minified sections output.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9315279 View commit details
    Browse the repository at this point in the history

  6. This is a bit cleaner.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1aa98ce View commit details
    Browse the repository at this point in the history

  7. Reordered sections should be list of keys.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    cb8e001 View commit details
    Browse the repository at this point in the history

  8. Pass tests again with new reorder yaml schema.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    512d8c6 View commit details
    Browse the repository at this point in the history

  9. Add helper to merge new reorder array style with legacy @inherit … 

    …style used everywhere.
    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5af5c3f View commit details
    Browse the repository at this point in the history

  10. Allow for new reorder array style when reordering sections.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6eb3011 View commit details
    Browse the repository at this point in the history

  11. Allow for new reorder array style when reordering items.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9191905 View commit details
    Browse the repository at this point in the history

  12. Allow for new reorder array style when reordering deeper child items.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    537c5e8 View commit details
    Browse the repository at this point in the history

  13. Fix normalization of reorder and children on deeper child items.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    95a0d7b View commit details
    Browse the repository at this point in the history

  14. Don’t normalize to reorder: false.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9fc40bc View commit details
    Browse the repository at this point in the history

  15. Pass test again, because method requires array/Collection arg input now.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    de07d1e View commit details
    Browse the repository at this point in the history

  16. Flesh out test coverage for new reorder: [] array style.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4ef4e80 View commit details
    Browse the repository at this point in the history

  17. Use assertSame to ensure object key order.

    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    45c540d View commit details
    Browse the repository at this point in the history

  18. Test legacy & array style config examples with reordering of sections… 

    …, items, and children.
    @jesseleite
    jesseleite committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b1b9db0 View commit details
    Browse the repository at this point in the history