Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib-parent to version 14 #76

Closed
wants to merge 2 commits into from
Closed

Update lib-parent to version 14 #76

wants to merge 2 commits into from

Conversation

diabonas
Copy link
Contributor

@diabonas diabonas commented Oct 7, 2019

Building with Maven 3.6.2 currently fails with

[ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:3.0.1:findbugs (findbugs) on project system-rules: Unable to parse configuration of mojo org.codehaus.mojo:findbugs-maven-plugin:3.0.1:findbugs for parameter pluginArtifacts: Cannot assign configuration entry 'pluginArtifacts' with value '${plugin.artifacts}' of type java.util.Collections.UnmodifiableRandomAccessList to property of type java.util.ArrayList -> [Help 1]

This is resolved in FindBugs version 3.0.4 and newer, so update lib-parent to a version including this fix. Using lib-parent version >14 breaks the current CI setup due to requiring a more recent Maven version.

OpenJDK 6 is no longer supported in the default build environment of
Travis CI, so downgrade to Ubuntu 14.04 LTS (Trusty Tahr). This version
is EOL (like Java 6), but seems to be the only way to continue building
with OpenJDK 6. Even with the downgraded build environment, a manual
workaround is necessary since the usual "jdk" key does not work.
Building with Maven 3.6.2 currently fails with

[ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:3.0.1:findbugs (findbugs) on project system-rules: Unable to parse configuration of mojo org.codehaus.mojo:findbugs-maven-plugin:3.0.1:findbugs for parameter pluginArtifacts: Cannot assign configuration entry 'pluginArtifacts' with value '${plugin.artifacts}' of type java.util.Collections.UnmodifiableRandomAccessList to property of type java.util.ArrayList -> [Help 1]

This is resolved in FindBugs version 3.0.4 and newer, so update
lib-parent to a version including this fix. Using lib-parent version >14
breaks the current CI setup due to requiring a more recent Maven
version.
@diabonas diabonas changed the title Update lib-parent to latest version 16 Update lib-parent to version 14 Oct 16, 2019
@diabonas
Copy link
Contributor Author

The first commit fixes the failing Travis CI build by reworking the OpenJDK 6 setup, which is necessary to unbreak #75 as well.

@stefanbirkner
Copy link
Owner

Thank you for your contribution and especially the pretty commit messges. I already merged your first commit: e638fdc. I have to check a few things before I can merge the second commit, too.

@stefanbirkner
Copy link
Owner

stefanbirkner commented May 17, 2020

In the meantime I inlined the lib-parent POM. For details see 4a6c78a Therefore i updated the FindBugs Maven plugin directly in System Rules' POM: 6bf863b

@diabonas diabonas deleted the update-lib-parent branch May 18, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants