Re-enable loadgen upgrade setup check #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably shouldn't be merged until after we've run the next set of max TPS tests for the next release because the old images don't have the loadgen fix in them. |
marta-lokhova
approved these changes
Aug 20, 2024
marta-lokhova
force-pushed
the
enable-upgrade-check
branch
from
fd13e44
to
bcd19e0
Compare
Closes stellar#180 This change enforces that soroban upgrade setup succeeds now that repeated calls to soroban upgrade setup are fixed in loadgen (see stellar/stellar-core#4425)
marta-lokhova
force-pushed
the
enable-upgrade-check
branch
from
bcd19e0
to
a53eb40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180
This change enforces that soroban upgrade setup succeeds now that repeated calls to soroban upgrade setup are fixed in loadgen (see stellar/stellar-core#4425)