Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate blockHeight argument #1193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spitko
Copy link
Contributor

@spitko spitko commented Jul 17, 2022

Fixes #1124

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch

@jiqiang90
Copy link
Contributor

Hi @spitko I wonder if there is a better approach for this, current approach will need run additional query for to get lastProcessedHeight in order to make comparison, this means we will have extra consumption for each query.

Is that possible to merge the comparison query and original query into one? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use future block height in historical state query
2 participants