Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat):add support for graphiql #2203

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0xJoichiro
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue) #1515

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@stwiname
Copy link
Collaborator

Hi @0xJoichiro thank you for contributing to SubQuery. This is on the right track but it should use the SubQuery styled version of GraphiQL. Could you please update to use this version.

@0xJoichiro
Copy link
Author

Hi @0xJoichiro thank you for contributing to SubQuery. This is on the right track but it should use the SubQuery styled version of GraphiQL. Could you please update to use this version.

understood

@0xJoichiro
Copy link
Author

@stwiname ser,we do not have a similar cdn for subql-components working on one and would add a pr there as well for the cdn support added an issue there => subquery/subquery-component-library#105

@stwiname
Copy link
Collaborator

@0xJoichiro can it be added as a dependency through npm?

@0xJoichiro
Copy link
Author

@0xJoichiro can it be added as a dependency through npm?

the issue was finished from your end it seems and would be making final changes asap

@stwiname
Copy link
Collaborator

@0xJoichiro do you plan on completing this?

@stwiname
Copy link
Collaborator

stwiname commented Jun 3, 2024

Hi @0xJoichiro this should be unblocked now if you wished to complete this.

See the dependent issue for details subquery/subquery-component-library#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants