Fix pbli157li90 #40
Open
Fix pbli157li90 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From when I tested it, it seems molecular mass was only needed for it as a mass fraction. |
gonuke
approved these changes
Aug 9, 2024
|
I'll wait for @bohmt to chime in before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32
I removed molecular mass from the material definition, since that gets calculated automatically when mixing by atom fraction. It is slightly different than the value entered manually before, but also now shows up in the JSON output. @bohmt do these seem like ok changes? Not sure what molecular mass was being used for before, or if it was just a fix for defining by mass fractions?