Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to chokidar 4 #2502

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Sep 13, 2024

Removes a dozen dependencies

blocked by paulmillr/chokidar#1349 and paulmillr/chokidar#1352

I added an ifMatching function, but then realized that perhaps ignored should be used instead after updating its types

@benmccann benmccann force-pushed the chokidar-4 branch 2 times, most recently from ec8e239 to ec8721b Compare September 13, 2024 03:10
@paulmillr
Copy link

Shouldn’t second arg be default = {} instead?

@benmccann
Copy link
Member Author

Chokidar does that be internally in the watcher constructor, so it shouldn't need to be done elsewhere

@benmccann benmccann marked this pull request as draft September 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants