Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change update option to update_as_unapproved #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joelnitta
Copy link

This preserves translations of changed strings and remove validations of those translations if they exist, instead of deleting the translation of the changed string

https://support.crowdin.com/developer/configuration-file/?_gl=1*t00g5h*_up*MQ..*_ga*MTQ2NTE3NTUwNS4xNzIwNTI0NjYw*_ga_SRNRQ29Q3E*MTcyMDUyNDY1OS4xLjAuMTcyMDUyNDY1OS4wLjAuMTczMDM5NjMxOQ#changed-strings-update

Should fix swcarpentry-ja#1

This preserves translations of changed strings and remove validations of those translations if they exist, instead of deleting the translation of the changed string

https://support.crowdin.com/developer/configuration-file/?_gl=1*t00g5h*_up*MQ..*_ga*MTQ2NTE3NTUwNS4xNzIwNTI0NjYw*_ga_SRNRQ29Q3E*MTcyMDUyNDY1OS4xLjAuMTcyMDUyNDY1OS4wLjAuMTczMDM5NjMxOQ#changed-strings-update
kozo2 added a commit to swcarpentry-ja/bioc-intro that referenced this pull request Sep 21, 2024
kozo2 added a commit to swcarpentry-ja/bioc-intro that referenced this pull request Sep 21, 2024
@kozo2
Copy link

kozo2 commented Sep 21, 2024

I confirmed that this PR

  1. does not remove the translation.
  2. moves the "SOURCE STRING" with changes from "Approved" to "Not approved".

with https://github.com/swcarpentry-ja/bioc-intro + https://bioconductor.crowdin.com/.

I replace the "SOURCE STRING" from dplyr to dplyr2.

ProofreadApprovedBefore

image

70perApproved

65perApproved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[crowdin] Translation disappears when text in source lesson is updated
2 participants