Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix truncated diagnostics on Windows #1082

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix truncated diagnostics on Windows #1082

merged 1 commit into from
Sep 19, 2024

Conversation

award999
Copy link
Contributor

  • We never want to resize the terminal regardless of if deployed or debug environment
  • If we are using conpty don't put large cols values as it will throw an error when task terminal opens
  • When we aren't using conpty (debugging) need to set a large cols value

Issue: #1074

@award999
Fix truncated diagnostics on Windows
1b6c21e 
* We never want to resize the terminal regardless of if
  deployed or debug environment
* If we are using conpty don't put large cols values as it
  will throw an error when task terminal opens
* When we aren't using conpty (debugging) need to set a
  large cols value

Issue: swiftlang#1074
@award999 award999 merged commit f527210 into swiftlang:main Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plemarquand plemarquand plemarquand approved these changes

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@award999 @plemarquand